Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Red Hat Konflux update acm-cli-acm-212 #10

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Red Hat Konflux update acm-cli-acm-212 #10

merged 6 commits into from
Sep 20, 2024

Conversation

red-hat-konflux[bot]
Copy link
Contributor

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 19, 2024

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhaiducek dhaiducek changed the base branch from release-2.12 to main September 19, 2024 15:29
@dhaiducek
Reflow Konflux YAML with yq
63d730d 
Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek dhaiducek changed the base branch from main to release-2.12 September 19, 2024 16:11
@dhaiducek dhaiducek changed the base branch from release-2.12 to main September 19, 2024 16:12
@dhaiducek dhaiducek force-pushed the appstudio-acm-cli-acm-212 branch 2 times, most recently from a7e5c80 to feaab46 Compare September 19, 2024 16:22
@dhaiducek
Copy link
Contributor

dhaiducek commented Sep 19, 2024 •
edited
Loading

Build failures are being addressed in:

@dhaiducek
Copy link
Contributor

/retest

@dhaiducek dhaiducek removed their request for review September 19, 2024 21:36
@dhaiducek dhaiducek self-assigned this Sep 19, 2024
@dhaiducek
Copy link
Contributor

/auto-cc

@dhaiducek dhaiducek removed their request for review September 19, 2024 21:36
@dhaiducek
Adjust PR CEL to main branch
9e89f53 
Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek
Add MintMaker config
087807f 
Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek
Remove subshell from script
fa6e0f0 
Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek
Add headers to CSV build file
e916e64 
Signed-off-by: Dale Haiducek <[email protected]>
JustinKuli
JustinKuli approved these changes Sep 20, 2024
View reviewed changes
Copy link

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, red-hat-konflux[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 044ef0f into main Sep 20, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the appstudio-acm-cli-acm-212 branch September 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinKuli JustinKuli JustinKuli approved these changes

@mprahl mprahl Awaiting requested review from mprahl

Assignees

@dhaiducek dhaiducek

@JustinKuli JustinKuli

Labels
approved dco-signoff: yes lgtm needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaiducek @JustinKuli